Fixed new template re-compilation issue #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a new template was added when the Phoenix server is running that new template wasn't being picked up by the CodeReloader because it wasn't being tracked. The originaly implementation copy-pasta'd the Phoenix LiveView implementation which gets around this because the template names are known AOT even if the template doesn't exist yet so that `@external_resource` was tracked but in LVN because we incorporate the TARGET into the template name (i.e. `home_live.swiftui+ios.neex`) we cannot use this method. The solution was to implement `__mix_recompile__?` and track file collection hashes for comparing if a new file was added or not that *should* be treated as a template for the given LiveView Native Render Component
bcardarella
force-pushed
the
bc-template-compile-issue
branch
from
0b8a86d to
858372f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a new template was added when the Phoenix server is running that new template wasn't being picked up by the CodeReloader because it wasn't being tracked. The original implementation copy-pasta'd the Phoenix LiveView implementation which gets around this because the template names are known AOT even if the template doesn't exist yet so that
@external_resourcewas tracked but in LVN because we incorporate the TARGET into the template name (i.e.home_live.swiftui+ios.neex) we cannot use this method. The solution was to implement__mix_recompile__?and track file collection hashes for comparing if a new file was added or not that should be treated as a template for the given LiveView Native Render Component